Better baseFee calculation (#1610).

ethers-io · Jun 15, 2021 · 91fff14 · 91fff14
1 parent c5bca77
commit 91fff14
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/packages/abstract-provider/src.ts/index.ts b/packages/abstract-provider/src.ts/index.ts
@@ -227,17 +227,22 @@ export abstract class Provider implements OnceBlockable {
     abstract getGasPrice(): Promise<BigNumber>;
     async getFeeData(): Promise<FeeData> {
         const { block, gasPrice } = await resolveProperties({
-            block: this.getBlock(-1),
-            gasPrice: this.getGasPrice()
+            block: this.getBlock("latest"),
+            gasPrice: this.getGasPrice().catch((error) => {
+                // @TODO: Why is this now failing on Calaveras?
+                //console.log(error);
+                return null;
+            })
         });
 
         let maxFeePerGas = null, maxPriorityFeePerGas = null;
 
         if (block && block.baseFee) {
-            maxFeePerGas = block.baseFee.mul(2);
-            //maxPriorityFeePerGas = BigNumber.from("1000000000");
-            // @TODO: This needs to come from somewhere.
-            maxPriorityFeePerGas = BigNumber.from("1");
+            // We may want to compute this more accurately in the future,
+            // using the formula "check if the base fee is correct".
+            // See: https://eips.ethereum.org/EIPS/eip-1559
+            maxPriorityFeePerGas = BigNumber.from("1000000000");
+            maxFeePerGas = block.baseFee.mul(2).add(maxPriorityFeePerGas);
         }
 
         return { maxFeePerGas, maxPriorityFeePerGas, gasPrice };