Skip to content

V3-Prelude updates since initial audit #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 74 commits into
base: v3-prelude-audit-report
Choose a base branch
from
Draft

V3-Prelude updates since initial audit #270

wants to merge 74 commits into from
+1,212 −675

Conversation

solipsis
Copy link
Contributor

@solipsis solipsis commented Jul 8, 2025

Very few changes actually effecting code since the

Functional changes:

  • fixed a bug where the guard clause of liquidityPool.confirmAndFundBeaconValidators was checking the wrong value
  • simplification / removal of unused tasks in Ether.fi Admin
  • Add a pure generateDepositDataRoot() helper function to StakingManager to be used by backend
  • EtherFiNode completeQueuedETHWithdrawals and sweepFunds now return the amount that was transferred for use in event in EtherFiNodeManager
  • added new role to liquidityPool LIQUIDITY_POOL_VALIDATOR_APPROVER_ROLE that is able to perform the validator staking actions
  • fixed

Non-functional changes:

  • rename deposit root generation functions to disambiguate between beacon deposit_root and deposit_data_root
  • new events emitted in EtherfiNodesManager and EtherFiNode
  • Many test updates and new tests
  • Documentation Updates
  • update version of forge stdlib

vvalecha519 and others added 30 commits February 19, 2025 16:20
@vvalecha519
rewards manager contract
7ceaac3
@vvalecha519
small improvements and started testing
4c4ec40
@vvalecha519
add end block for rewards calculated
6014973
@vvalecha519
undo pranking
530261a
@vvalecha519
more tests ready for audit
adc2381
@vvalecha519
cummulative merkle
f5ca203
@vvalecha519
add pausing feature
502ad67
@vvalecha519
add modifier
a671e5b
@vvalecha519
make pretty
af87f6a
@vvalecha519
add whitelisted user can only claim
28c8efc
@vvalecha519
delete old rewards manager
ff1da11
@vvalecha519
fix comment
9b18792
@vvalecha519
fixed tessting and fixed small bug
982625e
@vvalecha519
fix l1 and l2
4ffd0d7
@vvalecha519
fix 11-i5
68fb3c6
@seongyun-ko
add more functions to EtherFiViewer
7750f09
@vvalecha519
update blockno to timestamp
60cbd9c
@vvalecha519
update role name
4172e90
@seongyun-ko
Merge pull request #230 from etherfi-protocol/v2.49
2d94cb8 
V2.49
@seongyun-ko
Add files via upload
a632d15 
Signed-off-by: syko <seongyun@postech.ac.kr>
@seongyun-ko
Merge pull request #247 from etherfi-protocol/seongyun-ko-patch-5
c581e1a 
Audit files for v2.49 protocol upgrade
@seongyun-ko
Rename EtherFi - Instant Withdrawal Merge into v2.49.pdf to 2025.03.2…
1628650 
…6 - Certora - EtherFi - Instant Withdrawal Merge into v2.49.pdf

Signed-off-by: syko <seongyun@postech.ac.kr>
@seongyun-ko
Merge pull request #248 from etherfi-protocol/seongyun-ko-patch-6
fd6fe79 
Rename EtherFi - Instant Withdrawal Merge into v2.49.pdf to 2025.03.2…
@seongyun-ko
Rename EtherFi - v2.49.pdf to 2025.03.26 - Certora - EtherFi - v2.49.pdf
e51e4b2 
Signed-off-by: syko <seongyun@postech.ac.kr>
@vvalecha519
Merge pull request #250 from etherfi-protocol/seongyun-ko-patch-8
18150d1 
Rename EtherFi - v2.49.pdf to 2025.03.26 - Certora - EtherFi - v2.49.pdf
@vvalecha519
deploy script
ddebd4c
@vvalecha519
add audit
c7cacbe
@vvalecha519
add roles md
1bef169
@vvalecha519
make pretty
977bdb1
@vvalecha519
add another role
d99eae1
seongyun-ko and others added 30 commits May 27, 2025 17:58
@seongyun-ko
Update DeployEtherFiViewer.s.sol
05e4783 
Signed-off-by: syko <seongyun@postech.ac.kr>
@seongyun-ko
Update DeployEtherFiViewer.s.sol
c31ddcb 
Signed-off-by: syko <seongyun@postech.ac.kr>
@vvalecha519
automate remainder and fix tests
6e1ea49
@vvalecha519
Merge pull request #265 from etherfi-protocol/vaibhav/fix-compliation…
3666d0e 
…-github-action

automate claiming withdrawal fee and fix tests
@vvalecha519
deprecate non validator spinup tasks
ad70513
@vvalecha519
make eth claimable by non-admin
7251e96
@vvalecha519
change address to bb address
31177e0
@vvalecha519
rename to validator approval instead of validatorManagement
e0fe153
@vvalecha519
add test to make sure the oracle changes work
6d5a033
@solipsis
re-add removed event for compatibility
539792d
@seongyun-ko
add 'EtherFiNode_withdrawableBalanceInExecutionLayer'
d8cc6b1
@seongyun-ko
Merge branch 'master' into syko/feature/update_viewer
cb3b46c 
Signed-off-by: syko <seongyun@postech.ac.kr>
@seongyun-ko
Merge pull request #263 from etherfi-protocol/syko/feature/update_viewer
fad49c2 
minor: update EtherFiViewer
@vvalecha519
Merge pull request #268 from etherfi-protocol/vaibhav/add-wd-claimer-…
3d00d11 
…role

make eth claimable by non-admin
@solipsis
wip better validator test setup
f45a635
@solipsis
debugging tests
78c8ac9
@solipsis
update forge-std version
9d2e6fe
@solipsis
finish validator helper
7106834
@solipsis
linking tests
6d0806c
@solipsis
cleanup
4bb269c
@solipsis
more test cleanup
298c5cf
@vvalecha519
add transfer event when eth is sweeped
e6b643b
@vvalecha519
Merge pull request #269 from etherfi-protocol/vaibhav/sweep-event
eb6ea94 
add transfer event when eth is sweeped
@solipsis
merge with master
150ff6e
@solipsis
update validator helper test
ad6485f
@solipsis
Merge branch 'wip-v3-prelude' of github.com:etherfi-protocol/smart-co…
950fbf0 
…ntracts into wip-v3-prelude
@solipsis
update weETH changes to be consistent with other v3-prelude upgrades
23fc891
@solipsis
add event for transferring eth from EtherFiNode
2c8bc93
@solipsis
add new role for validator confirmations in liquidity pool
7146add
@solipsis
disambiguate deposit_data_root and deposit_root
6aca5fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solipsis @vvalecha519 @seongyun-ko