-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
Hey @wemeetagain! Thanks for this contribution. While this is backward compatible, its tests won't run in Node 8. We are currently trying to define a policy about which versions of Node to support, so we may not be able to merge it just yet. You can read more about it here. |
Okydoky, it looks like the consensus is to wait until Node 8 goes out of maintenance (Dec 31) to put any sort of policy in motion? Feel free to close / ignore this PR until the time is right. |
@alcuadrado would it make sense to support some kind of shim for this? |
AFAIK there's no way to shim native bigints. Maybe a partial shim can be implemented for this tests though. |
bump :) |
Sorry, my |
This change is meant to be backwards compatible. The only change to the generated js should be the additional The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wemeetagain, this looks good, will merge now.
Is this just generally useful contribution, or do you need this as some basis for further work and should we do a release (patch level I would guess?) on this?
The logic for
number
encoding works fine forbigint
s.bigint
toInput
typetypeof
check to allowbigint
encoding to sharenumber
encoding code pathbigint
encoding