-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flat database layout #780
base: master
Are you sure you want to change the base?
Flat database layout #780
Conversation
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
- Coverage 92.06% 86.40% -5.67%
==========================================
Files 46 19 -27
Lines 3025 1221 -1804
Branches 471 188 -283
==========================================
- Hits 2785 1055 -1730
+ Misses 145 127 -18
+ Partials 95 39 -56
Continue to review full report at Codecov.
|
This pull request introduces 10 alerts when merging 080baaa into 094d24b - view on LGTM.com new alerts:
|
"This branch is 10 commits ahead, 112 commits behind master." @s1na let me know if you need help with rebasing this branch! |
@evertonfraga hah thanks for the offer, I'll give it a try and ask for help if it got too complicated. But it should be fine since I didn't modify the existing codebase all that much. I'm just having problems with CI... |
This is actually still an extremely interesting PR laying around (and actually: a dramatically huge one) and it is likely worth to really do some deep dive and re-pick up. This might also fit well with our StateManager modularization (this is actually also a separate StateManager in this PR with a flat DB design). Sina, can you give a judgement: is this also already half the way through to a base design for snap sync? Or is this not as related as I would think? |
No description provided.