Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat database layout #780

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Flat database layout #780

wants to merge 14 commits into from

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jun 16, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #780 into master will decrease coverage by 5.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
- Coverage   92.06%   86.40%   -5.67%     
==========================================
  Files          46       19      -27     
  Lines        3025     1221    -1804     
  Branches      471      188     -283     
==========================================
- Hits         2785     1055    -1730     
+ Misses        145      127      -18     
+ Partials       95       39      -56     
Flag Coverage Δ
#account 94.11% <ø> (ø)
#block 82.87% <ø> (-5.49%) ⬇️
#blockchain 89.22% <ø> (+0.07%) ⬆️
#common 93.78% <ø> (ø)
#ethash 86.30% <ø> (?)
#tx 94.02% <ø> (ø)
#vm ?
Impacted Files Coverage Δ
packages/block/src/header.ts 66.94% <0.00%> (-21.59%) ⬇️
packages/block/src/block.ts 71.15% <0.00%> (-14.15%) ⬇️
packages/tx/src/transaction.ts 94.73% <0.00%> (ø)
packages/vm/lib/exceptions.ts
packages/vm/lib/runCode.ts
packages/vm/lib/evm/eei.ts
packages/vm/lib/index.ts
packages/vm/lib/runCall.ts
packages/vm/lib/bloom/index.ts
packages/vm/lib/state/cache.ts
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8b314...4db166a. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2020

This pull request introduces 10 alerts when merging 080baaa into 094d24b - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

@evertonfraga
Copy link
Contributor

"This branch is 10 commits ahead, 112 commits behind master."

@s1na let me know if you need help with rebasing this branch!

@s1na
Copy link
Contributor Author

s1na commented Jun 17, 2020

@evertonfraga hah thanks for the offer, I'll give it a try and ask for help if it got too complicated. But it should be fine since I didn't modify the existing codebase all that much.

I'm just having problems with CI...

@evertonfraga evertonfraga changed the title [WIP] Flat database layout Flat database layout Jun 30, 2020
@holgerd77
Copy link
Member

This is actually still an extremely interesting PR laying around (and actually: a dramatically huge one) and it is likely worth to really do some deep dive and re-pick up.

This might also fit well with our StateManager modularization (this is actually also a separate StateManager in this PR with a flat DB design).

Sina, can you give a judgement: is this also already half the way through to a base design for snap sync? Or is this not as related as I would think?

@scorbajio scorbajio mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants