-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP 6110 fixes #3397
EIP 6110 fixes #3397
Conversation
Current status
|
That's a promising start! |
I wonder if we're not encoding the other 3 fields correctly (e.g. they're BE in the event but should be LE in the request)? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
I just fixed it, all tests now pass! For some reason extracting LE Uint64 using DataView did not work, so I settled on this by manually converting the LEs to BEs. |
Just need to adjust the error message the test checks for and this will be ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR runs these 6110 tests: https://github.com/ethereum/execution-spec-tests/files/15101579/fixtures_develop.tar.gz
(only activate 6110 and 7685 in common)