-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block: make withdrawals trie check consistent with txtrie #3338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When working on #3336 I noticed some inconsistent things unrelated to EIP 7002.
This PR fixes that. (Have currently set it up to not run CI yet since I might want to add other things I find)
Currently:
return equalsBytes(this.keccakFunction(RLP.encode([])), this.header.uncleHash)
, this is unnecessary especially since we currently have no uncles)