-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cancun Pyspec tests #2944
Fix Cancun Pyspec tests #2944
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tests all pass (provided by Mario as release fixtures are currently broken)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We currently fail Pyspec tests for Cancun, notably: EIP 6780 tests. This PR fixes the problems.
This PR fixes these fixtures: https://github.com/ethereum/execution-spec-tests/releases/tag/v1.0.1
Note: there is a bug in the fixture release, these tests are failing:
This is a bug in the fixtures and is resolved here: ethereum/execution-spec-tests#245
To test, download the fixture release, then unpack into
./packages/ethereum-tests/BlockchainTests
(for instance unpack it in the dir "pyspec"). Then in VM:npm run test:blockchain -- --fork=Cancun --dir=pyspec
wherepyspec
is the dir of the fixtures you just unpacked. (Note: it is also fine to run all Cancun tests, but this will likely run more tests than just the fixtures)