Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cancun Pyspec tests #2944

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Fix Cancun Pyspec tests #2944

merged 4 commits into from
Aug 8, 2023

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Aug 7, 2023

We currently fail Pyspec tests for Cancun, notably: EIP 6780 tests. This PR fixes the problems.

This PR fixes these fixtures: https://github.com/ethereum/execution-spec-tests/releases/tag/v1.0.1

Note: there is a bug in the fixture release, these tests are failing:

    "000-fork=Cancun-one_full_blob_one_tx"
    "001-fork=Cancun-one_full_blob_max_txs"
    "002-fork=Cancun-one_full_blob_at_the_end_max_txs"

This is a bug in the fixtures and is resolved here: ethereum/execution-spec-tests#245

To test, download the fixture release, then unpack into ./packages/ethereum-tests/BlockchainTests (for instance unpack it in the dir "pyspec"). Then in VM:

npm run test:blockchain -- --fork=Cancun --dir=pyspec where pyspec is the dir of the fixtures you just unpacked. (Note: it is also fine to run all Cancun tests, but this will likely run more tests than just the fixtures)

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2944 (92f5b11) into master (f8605a0) will decrease coverage by 0.04%.
The diff coverage is 73.17%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <ø> (ø)
blockchain 92.58% <ø> (ø)
client 87.45% <ø> (ø)
common 98.64% <ø> (ø)
ethash ∅ <ø> (∅)
evm 69.93% <73.17%> (-0.03%) ⬇️
rlp ∅ <ø> (∅)
statemanager 85.16% <ø> (ø)
trie 89.98% <ø> (-0.25%) ⬇️
tx 95.96% <ø> (ø)
util 86.77% <ø> (ø)
vm 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer jochem-brouwer marked this pull request as ready for review August 8, 2023 12:48
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests all pass (provided by Mario as release fixtures are currently broken)

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jochem-brouwer jochem-brouwer merged commit 60e4def into master Aug 8, 2023
40 of 41 checks passed
@holgerd77 holgerd77 deleted the fix-pyspecs-cancun branch July 11, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants