Monorepo: JSON -> JS Transition #2911
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| throw new Error(`${eip} not supported`) | ||
| } | ||
| const minHF = this.gteHardfork(EIPs[eip]['minimumHardfork']) | ||
| const minHF = this.gteHardfork((EIPs as any)[eip]['minimumHardfork']) |
There was a problem hiding this comment.
Here and at some more places are some any typings left. This has the reasoning that we would otherwise have to hard-specify the EIP numbers again at the typing level, and this would eventually limit the expandability of the library.
At the same time I think typing has already significantly improved since the format now is already checked for the configuration objects themselves.
No strong opinion on this though.
|
Sounds good. Will take another look later and can pick things up if able and try and push this over the line. |
|
Updated this via UI |
|
Thanks for merging |
This PR transitions all monorepo JSON configuration files to JS for better typing and not to have to deal with adding type assertions to the ESM build or not, since this is has a usage conflict between Node.js (JSON type assertion required from Node 16 upwards) and browser (not fully supported, e.g. Firefox not supported at all).