Skip to content

Monorepo: Post-Build JSON Type Assertion Addition #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Monorepo: Post-Build JSON Type Assertion Addition #2908

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8de257b
Add JSON type assertion addition find/sed command to ts-build.sh
holgerd77 Jul 20, 2023
2a8317a
Replace rm with find command (rm wildcard subfolder path not working)
holgerd77 Jul 20, 2023
de2b48f
Merge branch 'master' into post-built-type-assertion-addition
ScottyPoi Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions config/cli/ts-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,21 @@ EOT
"type": "module"
}
EOT
echo "Adding JSON type assertions for ESM build"
# Following command is designed to be both Mac OS and GNU Linux (Ubuntu) compatible.
#
# Some notes:
# - Usage of both -i and -e is needed for Mac OS compatibility
# https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux
#
# - Then -i option behavior differs between Mac OS and Linux (Mac OS creates backup files with -i'')
# Therefore the explicit addition of -i'.js-e' and the subsequent deletion
#
# - Using sed with a direct path minimally doesn't work using the command within this script on Mac OS
# Therefore the usage with the find command
#
find dist/esm -name "*.js" -exec sed -E -i'.js-e' -e "s/(from '[^']+\.json');/\1 assert { type: \"json\" };/" {} \;
find ./dist/esm -name "*.js-e" -type f -delete
else
echo "Skipping post build fixes (no ESM setup yet)."
fi
Expand Down