Util: bytes cleanup + do not import from ethereum-cryptography/utils

[jochem-brouwer]

Closes #2843

This PR:

• Renames prefixedHexStringToBytes to hexStringToBytes
• Renames bytesToPrefixedHexString to bytesToHex
• Ensures that there are no imports from ethereum-crypto/utils (re-exported from util's bytes)
• All remaining task from the Util/Monorepo: Clean-Up bytes module Usage / Remove ethereum-cryptography helper usage #2843 issue

TODOs

• All tasks in the linked issue
• Add lint rule preventing imports from ethereum-cryptography/utils
• Verify in entire repo there are no more occurences of prefixedHexStringToBytes and bytesToPrefixedHexString
• Upgrade performance of hexToBytes (do not slice + pad, this copies the string) - will go in a different PR, this commit b079375 breaks tests. See Update bytes performance #2848

[jochem-brouwer]

Hmm great, merge conflicts.

Anyways, will stop for today. There are 2 test suits failing: wallet (seems to hang?) and client.

To debug keep this in mind:

The new bytesToHex is what was (and is re-exported) bytesToUnprefixedHex.

The new hexToBytes is what was (and is re-exported) unprefixedHexToBytes

[codecov]

Codecov Report

Merging #2845 (e7592ed) into master (499c496) will increase coverage by 0.04%.
The diff coverage is 89.33%.

Additional details and impacted files

Flag	Coverage Δ
block	89.16% <95.00%> (-0.02%)	⬇️
blockchain	92.52% <92.10%> (+0.01%)	⬆️
client	87.08% <86.50%> (+<0.01%)	⬆️
common	97.06% <100.00%> (-0.01%)	⬇️
devp2p	86.95% <85.29%> (+0.01%)	⬆️
ethash	?
evm	66.99% <83.78%> (-0.01%)	⬇️
rlp	∅ <ø> (∅)
statemanager	86.41% <96.22%> (-0.05%)	⬇️
trie	90.36% <87.50%> (+0.34%)	⬆️
tx	95.96% <100.00%> (-0.01%)	⬇️
util	86.54% <93.75%> (+0.46%)	⬆️
vm	77.25% <78.26%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[jochem-brouwer]

Remove toUtf8 in 21d26fe

[jochem-brouwer]

Performance will go in a different PR because my changes in b079375 broke tests

[holgerd77]

OMG is this an insane PR.

Have nevertheless forced me to go at least once through the whole thing.

Beautiful.

🤩

LGTM.