Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockchain: remove genesis state dependancy from blockchain #2844

Merged
merged 10 commits into from
Jul 5, 2023
Merged

blockchain: remove genesis state dependancy from blockchain #2844

merged 10 commits into from
Jul 5, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jun 30, 2023 •
edited
Loading

Remove genesis state dependancy from blockchain

  • fix the blockchain interface and create/init
    • remove genesis ref and have and use a genesis state root enum for known chain
  • get the build working and get client working for a know chain like mainnet
    • test
  • get client working for custom i.e. pass genesis data from client/chain's init
    • test
  • remove the dependancy from the blockchain package
  • fix tests
    • statemanager
    • blockchain
    • vm
    • client
  • add/cleanup jsdocs

@g11tech g11tech added PR state: WIP package: blockchain target: master Work to be done towards master branch labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jul 2, 2023 •
edited
Loading

Codecov Report

Merging #2844 (56b9afb) into master (ef133de) will increase coverage by 0.09%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
vm 77.37% <85.71%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech force-pushed the free-blockchain branch 3 times, most recently from e459ea4 to fe19e79 Compare July 5, 2023 08:36
@g11tech
blockchain: remove genesis state dependancy from blockchain
fdb0658 
fix the blockchain init and statepassing from client

pass custom genesis from client's chain to blockchain

simplify stateroot fetch

remove need to genesis state in blockchain

remove package dependancy

rebase fixes

lint

fix statemanager spec

fix vm spec

fix client spec

fix client spec
@g11tech
lint
43d6b45
@g11tech
address genesisstate in test helper
df83745
@g11tech
fix client spec
1f75f17
@g11tech
add as a dev dependancy in trie for tests
28b2d65
@g11tech
cleanup genesis state references in client and add some comments
2337f06
@g11tech
further cleanup genesis state passing
5105d7d
@g11tech
improve jsdocs
5b581c7
@g11tech
fix jsdocs
fadc010
holgerd77
holgerd77 previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🥳

Thanks a lot for having worked this through!

LGTM. Will merge.

@holgerd77
Copy link
Member

Update: ah, there are still 2 client tests failing.

@holgerd77 holgerd77 merged commit 79761c1 into master Jul 5, 2023
@holgerd77 holgerd77 deleted the free-blockchain branch July 5, 2023 11:43
@ethereumjs ethereumjs deleted a comment from Hg6f9 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: blockchain package: client package: common package: mpt package: statemanager package: vm PR state: merge ready target: master Work to be done towards master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g11tech @holgerd77