Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check VM nightly tests status #2836

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Check VM nightly tests status #2836

merged 1 commit into from
Jun 28, 2023

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Jun 28, 2023 •
edited
Loading

Closes #2831

@jochem-brouwer
Copy link
Member Author

Hmm, OK, can now also reproduce locally

@jochem-brouwer
Copy link
Member Author

image

VM api tests build & pass: https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/5402365031/jobs/9813541710?pr=2836 so open for review

@jochem-brouwer jochem-brouwer marked this pull request as ready for review June 28, 2023 15:03
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2836 (eafaaf8) into master (9f46c95) will decrease coverage by 6.58%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.13% <ø> (?)
blockchain 92.50% <ø> (?)
client ?
ethash ?
evm 66.99% <ø> (?)
trie 90.05% <ø> (?)
tx 95.97% <ø> (ø)
util 85.93% <ø> (?)
vm 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets do a fast follower soon to remove webpack entirely from the client and not forget to remove this devDependency

@acolytec3 acolytec3 merged commit 36aea11 into master Jun 28, 2023
@holgerd77 holgerd77 deleted the nightly-tests-failing branch June 29, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: monorepo package: vm PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monorepo: VM Nightly tests are failing
2 participants
@jochem-brouwer @acolytec3