EVM: move KZG precompile #2811
Merged
EVM: move KZG precompile #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, note: ethereum/EIPs#7214 We can also remove this multiple-precompiles-at-same-address logic 😅 (if that PR gets merged) |
evm: cleanup precompile getter
jochem-brouwer
added
the
type: test all hardforks
…s/ethereumjs-monorepo into update-4844-precompile-address
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
reviewed
Jun 22, 2023
|
|
||
| interface Precompiles { | ||
| [key: string]: PrecompileFunc | ||
| interface PrecompileEntry { |
g11tech
reviewed
Jun 22, 2023
| if (precompileFunc !== undefined) { | ||
| precompileMap.set(addressString, precompileFunc) | ||
| if ( | ||
| (type === PrecompileAvailabilityCheck.Hardfork && common.gteHardfork(entry.check.param)) || |
|
Oh, yeah, that's a really nice PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
ethereum/EIPs#7172 (move KZG)
ethereum/EIPs#7214 (move BLS)
This PR also makes it possible to have multiple precompiles at the same address (of course, only one is active at the same time).
It also exports this precompileAvailability.
Note: we could consider removing the
precompilesas well (we export it but I don't think it's used anywhere)