Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Limit blobs as per the maxDataGasPerBlock for block building #2661

Merged
merged 7 commits into from
Apr 26, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Apr 24, 2023

Currently ethereumjs can pack more than allowed blobs into a block which causes block rejection by the CL.
This is rectified by enforcing the allowed blobs limit while picking transactions for building a block.

TODO:

  • add spec tests

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop-v7@11e1bff). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.64% <0.00%> (?)
blockchain 90.45% <0.00%> (?)
client 87.05% <0.00%> (?)
common 95.76% <0.00%> (?)
devp2p 91.72% <0.00%> (?)
ethash ∅ <0.00%> (?)
evm 79.35% <0.00%> (?)
statemanager 88.19% <0.00%> (?)
trie 90.39% <0.00%> (?)
tx 95.45% <0.00%> (?)
util 81.50% <0.00%> (?)
vm 84.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech marked this pull request as ready for review April 26, 2023 06:00
@g11tech g11tech changed the title client: Limit blobs per block as per the specs client: Limit blobs as per the maxDataGasPerBlock for block building Apr 26, 2023
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! 👍

Will merge.

@holgerd77 holgerd77 merged commit cda9043 into develop-v7 Apr 26, 2023
@holgerd77 holgerd77 deleted the g11tech/blobs-per-block branch April 26, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants