Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataGasUsed to txReceipt and result #2620

Merged
merged 12 commits into from
Apr 14, 2023

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Apr 5, 2023

This adds the dataGasUsed field to the TxResult and also adds a new receipt type for blob transactions which includes the DataGasUsed and DataGasPrice values in the receipt.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop-v7@a14669d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.44% <0.00%> (?)
blockchain 90.43% <0.00%> (?)
client 86.99% <0.00%> (?)
common 95.76% <0.00%> (?)
devp2p 91.91% <0.00%> (?)
ethash ∅ <0.00%> (?)
evm 79.33% <0.00%> (?)
rlp ∅ <0.00%> (?)
statemanager 87.47% <0.00%> (?)
trie 90.39% <0.00%> (?)
tx 95.45% <0.00%> (?)
util 81.50% <0.00%> (?)
vm 84.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech force-pushed the add-datagasused-to-receipt/txresult branch from b153024 to ce9d6a2 Compare April 7, 2023 06:56
g11tech
g11tech previously approved these changes Apr 7, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acolytec3
Copy link
Contributor Author

I vote we don't merge this for now. It shouldn't be too much work to rebase it if'/when the corresponding spec update happens so no point in adding it now when there's no real world use for it.

@g11tech g11tech marked this pull request as draft April 7, 2023 16:24
@acolytec3 acolytec3 changed the base branch from master to develop-v7 April 13, 2023 18:52
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@acolytec3 acolytec3 merged commit 158b750 into develop-v7 Apr 14, 2023
@holgerd77 holgerd77 deleted the add-datagasused-to-receipt/txresult branch June 6, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants