Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codecov: configure threshold for patch status check #1160

Merged
merged 2 commits into from
Mar 22, 2021
Merged

codecov: configure threshold for patch status check #1160

merged 2 commits into from
Mar 22, 2021

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Mar 22, 2021

This PR:

  • Configures the threshold for the codecov patch status check to 5% (docs link)
  • Removes duplicate codecov.yml files, preferring one at the top level of the monorepo
  • Removes deprecated base property

@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #1160 (2be5062) into master (4672761) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 81.78% <ø> (-0.04%) ⬇️
blockchain 84.13% <ø> (-0.07%) ⬇️
client 83.86% <ø> (-0.17%) ⬇️
common 87.39% <ø> (+0.52%) ⬆️
devp2p 84.32% <ø> (ø)
ethash 82.08% <ø> (ø)
tx 84.06% <ø> (-0.20%) ⬇️
vm 81.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks, LGTM

@holgerd77 holgerd77 merged commit 4bd73d1 into master Mar 22, 2021
@holgerd77 holgerd77 deleted the codecov-patch-threshold branch March 22, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: monorepo type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanio @holgerd77