Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Commit

Permalink
lint, test cmd without cli, remove now-unneeded karma exclude
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanio committed Nov 12, 2020
1 parent 2623c5a commit 5b98930
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
2 changes: 0 additions & 2 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ module.exports = function (config) {

files: ['lib/**/*.ts', 'test/blockchain/chain.spec.ts'],

exclude: ['test/integration/**/*.ts', 'test/cli/**/*.ts'],

preprocessors: {
'**/*.ts': ['karma-typescript'],
},
Expand Down
2 changes: 1 addition & 1 deletion lib/net/server/rlpxserver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class RlpxServer extends Server {
*/
async stop(): Promise<boolean> {
if (this.started) {
this.rlpx!.destroy() // eslint-disable-line no-extra-semi
this.rlpx!.destroy()
this.dpt!.destroy()
await super.stop()
this.started = false
Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@
"build:browser": "tsc -p ./tsconfig.browser.json && npm run bundle && rm -rf dist.browser",
"bundle": "webpack",
"client:start": "ts-node bin/cli.ts",
"coverage": "nyc npm run coverage:test && nyc report --reporter=lcov",
"coverage:test": "npm run tape -- 'test/**/*.spec.ts'",
"coverage": "nyc npm run test && nyc report --reporter=lcov",
"docs:build": "typedoc --tsconfig tsconfig.prod.json",
"lint": "ethereumjs-config-lint",
"lint:fix": "ethereumjs-config-lint-fix",
"tape": "tape -r ts-node/register",
"test": "npm run tape -- 'test/**/*.spec.ts'",
"test": "npm run tape -- 'test/!(cli)/**/*.spec.ts'",
"test:unit": "npm run tape -- 'test/!(integration|cli)/**/*.spec.ts'",
"test:integration": "npm run tape -- 'test/integration/**/*.spec.ts'",
"test:cli": "npm run build:node && npm run tape -- 'test/cli/*.spec.ts'",
Expand Down
3 changes: 2 additions & 1 deletion test/cli/cli.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import tape from 'tape'
tape('[CLI]', (t) => {
t.test('should begin downloading blocks', { timeout: 260000 }, (t) => {
const file = require.resolve('../../dist/bin/cli.js')
const child = spawn(process.execPath, [file])
const args = [file, '--loglevel', 'debug']
const child = spawn(process.execPath, args)

const timeout = setTimeout(() => {
child.kill('SIGINT')
Expand Down

0 comments on commit 5b98930

Please sign in to comment.