Typos, formatting, and inconsistent definitions #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Isweet
commented
Mar 10, 2016
Isweet
commented
- Typo in equation (105), the 3rd return value shouldn't be \textbf{s} (which represents suicides), it should be A to represent substate.
- Also in (105), definition was overlapping with equation label, so added some extra whitespace with \qquad
- The definition of \Xi expanded the substate in the return, which I think is confusing. I changed it back to A. If you think this is confusing, I think the reader should be redirected back to the definition of substate in section 6.1
- The definition of O, the stepping function, was defined as taking a tuple, but was called in the definition of X as a function of four arguments. Since O never takes the result of another function which returns a tuple, it makes more sense to define it in function notation.
| @@ -239,7 +239,7 @@ \subsection{The Transaction} \label{ch:transaction} | |||
| \item[gasLimit] A scalar value equal to the maximum amount of gas that should be used in executing this transaction. This is paid up-front, before any computation is done and may not be increased later; formally $T_g$. | |||
| \item[to] The 160-bit address of the message call's recipient or, for a contract creation transaction, $\varnothing$, used here to denote the only member of $\mathbb{B}_0$ ; formally $T_t$. | |||
| \item[value] A scalar value equal to the number of Wei to be transferred to the message call's recipient or, in the case of contract creation, as an endowment to the newly created account; formally $T_v$. | |||
| \item[v, r, s] Values corresponding to the signature of the transaction and used to determine the sender of the transaction; formally $T_w$, $T_r$ and $T_s$. This is expanded in Appendix \ref{app:signing}. | |||
| \item[w, r, s] Values corresponding to the signature of the transaction and used to determine the sender of the transaction; formally $T_w$, $T_r$ and $T_s$. This is expanded in Appendix \ref{app:signing}. | |||
|
mostly good, but @subtly 's comment is correct |
gavofyork
requested changes
Sep 22, 2016
|
@Isweet can you please rebase and apply the requested changes? |
gavofyork
requested changes
Mar 30, 2017
|
Will take care of this over the weekend. |
|
This PR was pretty outdated w.r.t. the current document, so I created a fresh PR (#283) that addresses the issues which were not addressed already (namely, only equation 105 still had one formatting issue and did not refer to A) |
pirapira
added a commit
that referenced
this pull request
Apr 11, 2017
Fix remaining issues from PR #167, namely equation 105
pirapira
pushed a commit
to pirapira/yellowpaper
that referenced
this pull request
Apr 25, 2017
pirapira
pushed a commit
to pirapira/yellowpaper
that referenced
this pull request
Jan 31, 2018
pirapira
pushed a commit
to pirapira/yellowpaper
that referenced
this pull request
Jan 31, 2018
pirapira
pushed a commit
to pirapira/yellowpaper
that referenced
this pull request
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.