Skip to content

Conversation

@enioxt
Copy link

@enioxt enioxt commented Oct 15, 2025

Closes #3707

Summary

This PR adds missing test coverage for Type 3 (blob) transactions that include accessList fields, combining EIP-4844 (blob transactions) and EIP-2930 (access lists).

Changes

  • ✅ Add test_async_send_raw_blob_transaction_with_access_list() - async version
  • ✅ Add test_send_raw_blob_transaction_with_access_list() - sync version

Technical Details

Both tests verify that blob transactions can include access lists and that both features work correctly together.

Test Structure:

  • Reuses existing patterns from lines 485-516 (blob test) and 59-91 (access list tests)
  • Maintains consistency with test suite structure
  • Uses same fixtures (async_w3, w3)
  • Validates both blobVersionedHashes and accessList presence

EIP References:

  • EIP-4844: Shard Blob Transactions (Type 3)
  • EIP-2930: Optional Access Lists

Gap Filled

Current test coverage:

  • ✅ Type 3 blob transactions WITHOUT access lists (line 485-516)
  • ✅ Type 1/2 transactions WITH access lists (lines 59-91)
  • ❌ Type 3 blob transactions WITH access lists ← This PR

Testing

These tests follow the same pattern as existing tests and use the same test infrastructure (eth-tester).

Closes ethereum#3707

This PR adds missing test coverage for Type 3 (blob) transactions
that include accessList fields, combining EIP-4844 and EIP-2930.

Changes:
- Add test_async_send_raw_blob_transaction_with_access_list()
- Add test_send_raw_blob_transaction_with_access_list()

Both tests verify that blob transactions can include access lists
and that both features work correctly together.

Technical details:
- Reuses existing test patterns (lines 485-516 for blobs, 59-91 for access lists)
- Maintains consistency with existing test structure
- Uses same fixtures (async_w3, w3)
- Validates both blobVersionedHashes and accessList presence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more transaction tests

1 participant