added function to tupleize lists inside (nested) dicts #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
hashable-attributedict-lists
branch
from
e1b8942 to
92adaea
Compare
pacrob
force-pushed
the
hashable-attributedict-lists
branch
from
92adaea to
c87efdd
Compare
|
Thanks for this @JustCallMeDavid ! I modified the testing a bit and will get the typing/linting sorted out, but the tupelizing function is great! |
|
Hi @pacrob, thanks a lot for the review and fixing up the tests, they look a lot better now. Linting and typing should pass now, but please have a look - not sure if it could not be done better (was having trouble getting the dict assignments to work with more precise types). |
|
Yep, I worked on the typing for a while and couldn't get anything more precise either. I'll get some other eyes on it just to check, but otherwise I think we're good. |
fselmo
reviewed
May 9, 2023
pacrob
force-pushed
the
hashable-attributedict-lists
branch
2 times, most recently
from
15ab889 to
a7f1b52
Compare
pacrob
force-pushed
the
hashable-attributedict-lists
branch
from
a7f1b52 to
ca74990
Compare
fselmo
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #2908
How was it fixed?
Tupleized (nested) lists to render them hash-able inside
AttributeDictinstancesCute Animal Picture
This is Rosie. Adoption profile here: https://www.petfinder.com/dog/rosie-61590987/ny/canastota/wanderers-rest-humane-association-ny79/