Adds async version of eth_getUncleCount methods #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
async_eth_uncles
branch
2 times, most recently
from
0031731
to
8848537
Compare
kclowes
force-pushed
the
async_eth_uncles
branch
from
8848537
to
fc66279
Compare
kclowes
approved these changes
Apr 7, 2023
|
I was able to run the full ci suite on #2909, so merging here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2822. Missing async version of
eth_getUncleCountJSON-RPC methods.How was it fixed?
Add
get_uncle_counttoAsyncEthclass, and add corresponding tests.Also updated the docs to include the new method.
Todo:
Cute Animal Picture