Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy example in docs #1684

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Jul 14, 2020

What was wrong?

A docs example contained a stale (deprecated) deploy() reference. I ran through the example locally and found I was unable to get off the ground without some other cleanup too.

Closes #1679

How was it fixed?

  • replaced deploy() with constructor().transact()
  • added PyEVMBackend. Without it, you get ValueError: RPC Endpoint has not been implemented: eth_estimateGas.
  • latest solidity requires emit keyword to trigger events
  • added py-solc-x for latest solidity compilation
  • other cleanup: formatting, etc. (some done by black)

Todo:

Cute Animal Picture

@pipermerriam
Copy link
Member

This would be something I would expect to be caught by doctest. I would recommend doing some investigating to 1) enable doctest on these examples if it isn't enabled or 2) figure out why doctest isn't catching these if it is already enabled.

@wolovim
Copy link
Member Author

wolovim commented Jul 14, 2020

Will check into bolstering these examples via doctests next. Shipping this update to get the next beta release out :shipit:

@wolovim wolovim merged commit b8507ea into ethereum:master Jul 14, 2020
@wolovim wolovim deleted the docs-deploy-cleanup branch July 14, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy() is used anywhere in the stable docs, and it was removed
2 participants