[ethPM] Update deployments to work when only abi available #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently
ethpm.deployments.get_instance()generates a contract factory for each deployment. This will break if manifest does not containdeployment_bytecodefor the corresponding contract type. It doesn't seem reasonable to expect a manifest to know the deployment bytecode for every deployment (for example, manifests generated from etherscan uris will have a deployments without deployment bytecode).ethpm.deployments.get_instance()was updated to generate contract instances rather than factories for each deployment, requiring only the necessary abi data to successfully construct a contract instance.Cute Animal Picture