Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry assets to simple solidity registry implementation #1400

Merged

Conversation

njgheorghita
Copy link
Contributor

What was wrong?

New simplified solidity registry implementation [here] is the default registry implementation moving forward. ethpm's assets folder needs updating to use this implementation.

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the ethpm-update-registry-contracts branch from 3bc1f79 to 9800a4c Compare July 26, 2019 19:51
Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to have you get 1-2 more people to look at this before merging just because it's smart contract code. They don't necessarily have to be solidity experts but more 👀 might catch something I missed.

return releaseId;
}

function cutRelease(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe name _cutRelease to signal privateness.

string memory version
)
public
view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. But the ERC / Interface define this function as view. Which looks to be the case b/c in the complex solidity implementation, it generates these values via the PackageDB and ReleaseDB. So, I left it as view here to maintain compatibility with the erc/ PackageRegistryInterface.

uint packageReleaseCount
)
private
pure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird indentation

@njgheorghita
Copy link
Contributor Author

I'm inclined to have you get 1-2 more people to look at this before merging just because it's smart contract code. They don't necessarily have to be solidity experts but more 👀 might catch something I missed.

Yup, doing that in ethpm/solidity-registry#1. The contract here is v2.0.0a1 - and will be updated to a stable version once ethpm/solidity-registry#1 is approved/merged.

@njgheorghita njgheorghita merged commit b6256ad into ethereum:master Jul 29, 2019
@njgheorghita njgheorghita deleted the ethpm-update-registry-contracts branch July 29, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants