Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deprecation Warning #1360

Merged
merged 1 commit into from
May 24, 2019
Merged

Fix Deprecation Warning #1360

merged 1 commit into from
May 24, 2019

Conversation

fubuloubu
Copy link
Contributor

Fixes #1359

Cute Animal Picture

silly giraffe

@fubuloubu
Copy link
Contributor Author

Unsure why the geth integration tests are failing, looks like it was unable to build?

Also unsure why test_get_contract_factory_with_valid_escrow_manifest failed. Seems unrelated?

p.s. I have no idea what I changed, I only followed the deprecation warning suggestion because it was annoying me. Please review accordingly! 😄

@kclowes
Copy link
Collaborator

kclowes commented May 23, 2019

Don't worry, these test failures aren't you. I fixed the same Geth problem a while back, but looks like I'll have to dig in again. Thanks @fubuloubu!

kclowes
kclowes approved these changes May 23, 2019
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fubuloubu fubuloubu changed the title [WIP] Fix Deprecation Warning Fix Deprecation Warning May 23, 2019
@kclowes
Copy link
Collaborator

kclowes commented May 23, 2019

For whatever reason, your repo has go1.12 in the .circleci/config.yml, which is parsed incorrectly by geth1.7. They changed the way they handle the go version parsing in 1.8, which is why the geth1.7 tests are failing. I dropped it down to go1.9.7 a while back which fixes the parsing issue, but for whatever reason (maybe because it's a dotfile?) Github isn't showing the file as different. If you have a minute to change from go1.12 to go1.9.7 here and here that would be great! If not, I'm happy to do it. Then, after this PR gets merged, these tests should be green and I'll merge this one! Phew!

@fubuloubu
bug: combine_argument_formatters is deprecated
b8d6bfc 
Changed to apply_formatters_to_sequence
@fubuloubu
Copy link
Contributor Author

fubuloubu commented May 23, 2019 •
edited
Loading

@kclowes forgot to rebase! Missing 43 commits... Sorry! 😬

@kclowes
Copy link
Collaborator

kclowes commented May 23, 2019

Aha! That'll do it. No worries! :)

@kclowes kclowes merged commit 609b465 into ethereum:master May 24, 2019
@fubuloubu fubuloubu deleted the formatters branch May 25, 2019 13:07
@AndreMiras AndreMiras mentioned this pull request Jun 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning
2 participants
@fubuloubu @kclowes