Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eth-tester backport #1333

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 15, 2019

What was wrong?

Same issue as #1332, just Backported to v4. Invalid opcode in Solidity 0.5.7 but not 0.5.3

Related to py-evm issue #1748

How was it fixed?

Pinned eth-tester py-evm requirement to 0.1.0-beta.39

Cute Animal Picture

cute-baby-animals-2

@carver
Copy link
Collaborator

carver commented Apr 17, 2019

At least one of the issues: v4 expects eth-tester to raise a KeyError when the sender account is missing, but eth-tester now raises a ValidationError. Since eth-tester is still experimental, I think it's okay to just change the API and expect the new exception.

@kclowes kclowes force-pushed the backport-upgrade-eth-tester branch from fcd2cda to 3e5018d Compare April 22, 2019 18:10
@kclowes kclowes force-pushed the backport-upgrade-eth-tester branch from 0355850 to 02582cd Compare April 22, 2019 22:32
@kclowes kclowes merged commit a493776 into ethereum:v4 Apr 22, 2019
@kclowes kclowes deleted the backport-upgrade-eth-tester branch April 22, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants