Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move miner module to geth namespace #1287

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Move miner module to geth namespace #1287

merged 1 commit into from
Mar 19, 2019

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Mar 18, 2019 •
edited
Loading

What was wrong?

Related to Issue #1273

How was it fixed?

Moved the Miner module to the geth namespace.

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the relocate-miner-module branch 2 times, most recently from b70cca2 to 472c481 Compare March 18, 2019 10:53
kclowes
kclowes approved these changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@njgheorghita njgheorghita merged commit a22c6cc into ethereum:master Mar 19, 2019
@njgheorghita njgheorghita deleted the relocate-miner-module branch March 19, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njgheorghita @kclowes