Added Goerli Infura Endpoint #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
requested changes
Apr 4, 2019
There was a problem hiding this comment.
Thank you @fubuloubu! I'm not sure why that test is failing, but I think it'll resolve itself if you run it again. If you have a minute, will you please add the _build_http_header method like in the current master branch? It allows users to use their Infura secret key if they so desire. If you don't have a minute, I'd be happy to do it, just let me know! Once that's in, I'll merge!
fubuloubu
commented
Apr 4, 2019
fubuloubu
commented
Apr 4, 2019
fubuloubu
commented
Apr 4, 2019
kclowes
reviewed
Apr 4, 2019
kclowes
approved these changes
Apr 4, 2019
|
Tests are fixed if you want to pull in the latest master. Then I'll merge! Thank you! |
- Build HTTP Headers so users can use their own keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1229
How was it fixed?
Copy & paste
NOTE: The Goerli endpoint does not accept unauthenticated requests (you must use your project ID for it to work)
Cute Animal Picture