Skip to content

Conversation

@njgheorghita
Copy link
Contributor

What was wrong?

My fat finger accidentally committed some .DS_Store files I only realized in retrospect in pr #1205
Deleted them in this PR

Cute Animal Picture

image

Copy link
Contributor

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, was about to comment on the last PR. Seems totally reasonable to add .DS_Store to .gitignore to prevent more accidents, too.

@njgheorghita
Copy link
Contributor Author

@carver 👍 Added *.DS-Store and .mypy_cache/ here (assuming that mypy is on the roadmap for web3 eventually). Also included the change to your most recent comment in #1205 in this pr

@pipermerriam
Copy link
Member

@njgheorghita you can have a global gitignore in your home directory where you add these as well which will prevent this from happening to you in the future across all of your repos. (but it's also good to have these in the local project's .gitignore as well.

@njgheorghita njgheorghita merged commit ae70776 into ethereum:master Jan 17, 2019
@njgheorghita njgheorghita deleted the remove-ds-store branch January 17, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants