Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth-utils dependencies and clean up other dependencies #1195

Conversation

pipermerriam
Copy link
Member

What does this do?

  • Updates eth-utils to latest version
  • removes some dead/commented-out dependencies
  • updates eth-abi to latest beta release in the 2.x line
  • drops the toolz dependencies in favor of relying on eth-utils to install them.

Cute Animal Picture

i2fun com_surprised_animals_39

@njgheorghita
Copy link
Contributor

Special request to also include updating eth-tester to the latest release: "eth-tester[py-evm]==0.1.0-beta.35". I can also add the commit if 👍

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't have any problem with updating eth-tester in this PR, but will defer to @pipermerriam

@njgheorghita njgheorghita force-pushed the piper/update-eth-utils-and-other-dependencies branch from 1acad01 to d1707b8 Compare January 10, 2019 10:03
@njgheorghita njgheorghita force-pushed the piper/update-eth-utils-and-other-dependencies branch from 197b5a0 to 952d4af Compare January 10, 2019 11:26
@njgheorghita
Copy link
Contributor

ping @pipermerriam - I updated the eth-tester dependency and pytest dependencies. Made a few tweaks caused by the eth-tester updates, but everything should be good to go

@pipermerriam pipermerriam merged commit 821902e into ethereum:master Jan 10, 2019
@pipermerriam pipermerriam deleted the piper/update-eth-utils-and-other-dependencies branch January 10, 2019 20:50
kclowes pushed a commit to pjryan93/web3.py that referenced this pull request Apr 25, 2019
…um#1195)

* Update eth-utils dependencies and clean up other dependencies

* Update eth-utils and pytest dependencies

* Update keyerror -> validationerror for mismatched from address in tests

* Update eth-tester to 0.1.0b36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants