Add extra verification for getTransactionReceipt (make sure blockHash is not None) #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolashardy
changed the title
nicolashardy
changed the title
pipermerriam
approved these changes
Dec 12, 2018
|
|
kclowes
force-pushed
the
nicolashardy-patch-1
branch
from
5807e43
to
1e56742
Compare
|
Wondering if you can get us a test in place within our integration test suite for this. https://github.com/ethereum/web3.py/blob/master/tests/integration/parity/common.py |
|
Actually this is already tested : https://github.com/ethereum/web3.py/blob/master/tests/integration/parity/common.py#L85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
wait for transaction receipt does not wait for blockhash to exist
How was it fixed?
added verification that blockHash is not None
Cute Animal Picture