Move all used datastructures from utils module #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The failing test is actually due to us querying the live token contract for the Unicorn tokens. Wondering if you can go and update that line to be 2039 for now until we come up with a better solution to still retain the example since I think it's a useful one, but to get things working for now. |
Member
|
I went ahead and did the update. good to go when tests ✔️ |
pipermerriam
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
As discussed in #1033,
web3.utils.datastructuresare used to type checks and shouldn't be treated as internal.How was it fixed?
I moved the datastructures.py from internal utils module to the public one. I wonder if I should be contained in a separate module instead of the top one.
Cute Animal Picture