Skip to content

Conversation

@Exef
Copy link
Contributor

@Exef Exef commented Aug 29, 2018

What was wrong?

Contract.eventFilter() method marked as deprecated and it should be removed in v5.
Related to Issue #1028

How was it fixed?

I removed the deprecated function, the test that used it and documentation about it.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@Exef
Copy link
Contributor Author

Exef commented Aug 30, 2018

Thank you, @dylanjw for fixing my errors.

Can you tell me, what have I done wrong with test fixture?

@dylanjw
Copy link
Contributor

dylanjw commented Aug 30, 2018

Thanks for contributing!

pytest fixtures can be parametrized, so that everytime a test uses that fixture, it is run with each parameter.

The fixture decorator @pytest.fixture(params=['v3', 'v4']) was passing both 'v3' and 'v4' values to return_filter_by_api. Because the 'v3' conditional was removed, in the case when 'v3' was passed the ValueError on this line 523f493#diff-e3a6abe3e92df49f9a94069e9a05f9e7L147 was being raised.

@pipermerriam
Copy link
Member

@dylanjw before this is merged we'll need to get a legacy v4 branch created to allow merging of these new v5 only features into master (and then anything that is a bugfix needs to be backported to v4)

@dylanjw dylanjw added this to the Version 5 Beta milestone Aug 30, 2018
@dylanjw
Copy link
Contributor

dylanjw commented Sep 19, 2018

The https://github.com/ethereum/web3.py/tree/v4 branch is up to date with 4.7.1

@carver carver merged commit 6577cd1 into ethereum:master Sep 19, 2018
@carver carver mentioned this pull request Feb 21, 2019
22 tasks
.. _event-log-object:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slug is referenced elsewhere in the docs (via :ref:), which produces a warning.

Section below also referenced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants