-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit docs and convert all Web3 instance variables to use w3
name.
#1183
Comments
Are there more instances that are looking to be updated @pipermerriam? @aherzfeld suggested "web3 is used as the variable for instances of web3 in many of the .py files" in the previous pull. Would that be good for consistency? |
It'd be good to be completely consistent across both |
I can take a crack at updating the .py files as well |
Hey there, I'm looking to make my first contribution to Web3.py (and first contribution to open-source, in general). Given that the issue is still marked as Open, I was wondering whether there is still something I can help with. |
@marcobesier Welcome! Yep, there are still many places in our docs where we us web3 instead of w3. |
Awesome! Will take a crack at making the update. |
@kclowes A quick comment on the pull-request: for now, I just updated the Also, since this is my first real contribution to open-source, please let me know in case I should do anything differently going forward regarding the pull-request submission. |
@pipermerriam I am a beginner in open source contribution. Can you please help me to start with. |
Hello, is this issue still active? I am willing to go through the docs and change them. |
Sorry, this should have been closed. It was handled in pr #2357 |
What was wrong?
A while back we settled on a convention of using
w3
as the variable name for an instance of theWeb3
object. We still have some places in the docs that use the oldweb3
name.How can it be fixed?
Check through the docs for code examples which use the variable name
web3
to represent an instance of theWeb3
object and convert them to usew3
instead.The text was updated successfully, but these errors were encountered: