Skip to content

Commit

Permalink
Refactor install extras:
Browse files Browse the repository at this point in the history
- Require `tester` for `test` install extra. The whole of the core
  test suite needs eth-tester to run and integration tests rely on
  py-geth.

- Leave dependencies needed for test runs only on the `test` extra,
  removing them from  the `dev` extra. The `dev` extra is re-defined
  below and pulls in all of the `test` extra dependencies.
  • Loading branch information
fselmo committed Sep 24, 2024
1 parent 9baae32 commit 8d23b09
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
1 change: 1 addition & 0 deletions newsfragments/3495.internal.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Re-organize the install extras. Re-define the ``test`` extra to always include the ``tester`` extra since it's needed for testing.
17 changes: 8 additions & 9 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,16 @@

extras_require = {
"tester": [
# Note: ethereum-maintained libraries in this list should be added to the
# `install_pre_releases.py` script.
"eth-tester[py-evm]>=0.11.0b1,<0.13.0b1",
"py-geth>=5.0.0",
],
"dev": [
"build>=0.9.0",
"bumpversion>=0.5.3",
"flaky>=3.7.0",
"hypothesis>=3.31.2",
"ipython",
"mypy==1.10.0",
"pre-commit>=3.4.0",
"pytest-asyncio>=0.21.2,<0.23",
"pytest-mock>=1.10",
"setuptools>=38.6.0",
"tox>=4.0.0",
"tqdm>4.32",
"twine>=1.13",
"wheel",
Expand All @@ -32,12 +27,15 @@
"towncrier>=21,<22",
],
"test": [
# Note: ethereum-maintained libraries in this list should be added to the
# `install_pre_releases.py` script.
"pytest-asyncio>=0.18.1,<0.23",
"pytest-mock>=1.10",
"pytest-xdist>=2.4.0",
"pytest>=7.0.0",
"flaky>=3.7.0",
"hypothesis>=3.31.2",
"tox>=4.0.0",
"mypy==1.10.0",
"pre-commit>=3.4.0",
],
}

Expand All @@ -47,6 +45,7 @@
+ extras_require["test"]
+ extras_require["tester"]
)
extras_require["test"] = extras_require["test"] + extras_require["tester"]


with open("./README.md") as readme:
Expand Down

0 comments on commit 8d23b09

Please sign in to comment.