Add tests which demonstrate issue #4 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control-C and/or signalling with SIGINT doesn't result in clean cancellation and teardown of a program that has spawned subproceses. These tests demonstrate this issue as is documented in ethereum#4.
goodboy
force-pushed
the
sigint_causes_hang
branch
from
cd7583e to
b4c8750
Compare
Just being double sure cancellation works on `run_in_process()` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control-C and/or signalling with SIGINT doesn't result in clean cancellation and teardown of a program that has spawned subproceses. Note that despite these tests relaying a signal via
os.kill()the same behavior exhibits by manually typingcontrol-Cfrom a unix shell.These tests demonstrate this issue as is documented in #4.