chore: fix confusing comment in E2HSManager #1857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
approved these changes
May 25, 2025
| @@ -60,7 +60,7 @@ impl E2HSManager { | |||
|
|
|||
| pub async fn last_fetched_block(&self) -> anyhow::Result<&ProcessedBlock> { | |||
| let Some(current_e2hs) = &self.current_e2hs else { | |||
| panic!("current_e2hs should always be present, perhaps it wasn't initialized in E2HSManager::new()?"); | |||
| bail!("No blocks were fetched yet, current_e2hs is initialized in get_next_block"); | |||
There was a problem hiding this comment.
Suggested change
| bail!("No blocks were fetched yet, current_e2hs is initialized in get_next_block"); | |
| bail!("No blocks were fetched yet, last_fetched_block is available only after successful get_next_block"); |
nit: I would phrase it like this. Up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There was some confusion on a confusing comment #1855 (comment)
How was it fixed?
Updating the comment to be more accuate