feat: add select_random_peers to census #1850
Merged
+39
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
approved these changes
May 23, 2025
Comment on lines
16
to
17
| content_key: Option<&impl OverlayContentKey>, | ||
| content_id: &Option<[u8; 32]>, |
There was a problem hiding this comment.
I think this should now be something like:
content_key_and_id: &Option<(&impl OverlayContentKey, [u8; 32])>
and line 26 should be:
let content_key_and_id = content_key.map(|key| (key, key.content_id()));
| @@ -108,7 +108,7 @@ impl Network { | |||
| /// Selects peers to receive content. | |||
There was a problem hiding this comment.
I think this documentation should clarify what happens in None is passed, something like:
Suggested change
| /// Selects peers to receive content. | |
| /// Selects peers to receive content. | |
| /// | |
| /// If content key is present, only peers interested in content will be returned. | |
| /// Otherwise, all peers are eligible. |
| @@ -123,7 +123,7 @@ impl<W: Weight> Peers<W> { | |||
| } | |||
|
|
|||
| /// Selects peers to receive content. | |||
| @@ -13,17 +13,20 @@ use super::peer::{Peer, PeerInfo}; | |||
| pub trait Weight: Send + Sync { | |||
| fn weight( | |||
There was a problem hiding this comment.
This should have a documentation as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
This is a chunk from #1846
select_peers()take a content_key this doesn't make when gossiping a series of EphemeralHeadersByOffer as we just want working random Enr'sHow was it fixed?
At the top level of
censusadd a functionselect_random_peers(), then just pass an option from there down.