Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constantinople transition test #547

Merged
merged 3 commits into from
Nov 19, 2018
Merged

constantinople transition test #547

merged 3 commits into from
Nov 19, 2018

Conversation

winsvega
Copy link
Collaborator

difficulty change test
reward change test

@lithp
Copy link
Contributor

lithp commented Dec 17, 2018

I'm trying to draw up some release notes and don't know what to say about this PR, this test didn't include a comment! What is this test testing for?

@lithp lithp added the breaking-change Items with this tag should be called out in release notes label Dec 17, 2018
@winsvega
Copy link
Collaborator Author

please read the PR description

@holgerd77
Copy link
Contributor

@winsvega to give such a self-referencing answer for someone asking for clarification is not sufficient. Please give a better explanation what's going on here.

@holgerd77
Copy link
Contributor

holgerd77 commented Dec 18, 2018

(or do you mean another description then these few words

difficulty change test
reward change test

description from above and I just haven't found?)

@winsvega
Copy link
Collaborator Author

Its a transition test to check that rules of a hardfork are activated at transition fork block. I did also tried to test difficulty and reward change for blocks including/not includeing uncles aftet transition point.

@winsvega winsvega deleted the consttransition branch September 5, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Items with this tag should be called out in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants