fix tests that were failing via RPC #437
Conversation
| @@ -2,10 +2,11 @@ | |||
| "createNameRegistratorPerTxsNotEnoughGas" : { | |||
| "_info" : { | |||
| "comment" : "", | |||
| "filledwith" : "cpp-1.3.0+commit.619a6438.Linux.g++", | |||
| "filledwith" : "cpp-1.3.0+commit.84983edf.Linux.g++", | |||
| "retesteth" : "cpp-0.0.1+commit.b346d8e6.Linux.g++", | |||
There was a problem hiding this comment.
retesteth commit hash
There was a problem hiding this comment.
I see. But can you rename it to something more generic. E.g. "client_version" and "tool_version". And why retesteth is called "cpp"?
There was a problem hiding this comment.
tool_version does not look more generic then retesteth
cpp states for cpp implementation
There was a problem hiding this comment.
@winsvega can you make it, something like
"filling-rpc-host-version" : "cpp-1.3.0+commit.84983edf.Linux.g++",
"filling-runner-version" : "retesteth-0.0.1+commit.abdcda.Linux.g++"
There was a problem hiding this comment.
@winsvega let's prepare for alternative implementations of retesteth and let's assume not all of them are called retesteth.
There was a problem hiding this comment.
filling-rpc-client
filling-tool-version
There was a problem hiding this comment.
@winsvega For consistency, you either add -version suffix or not.
There was a problem hiding this comment.
@winsvega cpp-ethereum is the RPC server, not the client. retesteth sends requests (client) and cpp-ethereum answers (server).
|
@winsvega please file a PR to |
How was it filled, exactly? What was used for input, and what API was used? |
|
the input is (which are not final and it's format will probably be changed) |
winsvega
changed the title
winsvega
changed the title
|
@winsvega should this be ready for merge? |
|
cpp-ethereum testeth would fail to pass this. |
|
@winsvega are you going to fix cpp-ethereum? |
|
the tests itself might be incorrect. now moving from test_addTransaction to eth_sendRawTransaction |
touched coinbase should exist in the post state
|
@pirapira a PR passing this branch has just been merged to cpp. |
Here is the first test filled with retesteth via RPC and custom cpp client version.
this test should be compatible with existing cpp-develop.