soltest: Improve handling invalid EVMVersion syntax in test files. #7916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
changed the title
christianparpart
force-pushed
the
fix-testcase-invalid-evmversion-handling
branch
from
e8706f5 to
4b7d7f8
Compare
|
NB: In my force-push I just updated the commit log message. |
erak
reviewed
Dec 6, 2019
christianparpart
force-pushed
the
fix-testcase-invalid-evmversion-handling
branch
from
4b7d7f8 to
04beee2
Compare
christianparpart
force-pushed
the
fix-testcase-invalid-evmversion-handling
branch
from
04beee2 to
48dd1e3
Compare
erak
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7594
Improves handling invalid
EVMVersionvalues in .sol test file's metadata section. Before you saw a huge mess of c++ source code when test test failed because of that.Now you see still an exception, but a much smaller and more descriptive one.