Set emscripten strict mode and remove obsolete option #5809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was made obsolete by using toolchain files (#2836)
|
Looks good but please squash. |
Codecov Report
@@ Coverage Diff @@
## develop #5809 +/- ##
============================================
+ Coverage 28.24% 88.25% +60.01%
============================================
Files 347 347
Lines 32970 33153 +183
Branches 3982 3982
============================================
+ Hits 9312 29260 +19948
+ Misses 22966 2535 -20431
- Partials 692 1358 +666
|
ekpyron
approved these changes
Jan 17, 2019
I've separated them because I don't feel they are linked together and the removal has the hash in the log. |
chriseth
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up #2836.
Pulled from #4441.