Yul grammar changes. #5524
Yul grammar changes. #5524
Conversation
chriseth
commented
Nov 28, 2018
chriseth
commented
- also the top level object needs to be named
- code is not optional
- also the top level object needs to be named - code is not optional
| @@ -559,8 +559,7 @@ regular strings in native encoding. For code, | |||
|
|
|||
| Grammar:: | |||
|
|
|||
| TopLevelObject = 'object' '{' Code? ( Object | Data )* '}' | |||
| Object = 'object' StringLiteral '{' Code? ( Object | Data )* '}' | |||
| Object = 'object' StringLiteral '{' Code ( Object | Data )* '}' | |||
There was a problem hiding this comment.
I think it should be 'object' StringLiteral '{' (Code | Object | Data )+ '}'
There was a problem hiding this comment.
I would not allow multiple code blocks - what happens to control flow at the end of the first code block? If you want to refer to code as data, you should wrap it inside a sub-object.
About objects without code: Do you see a use-case? We can allow it at some later point, if we want, but for now, I would require code - the code itself can be empty, though.
| @@ -559,8 +559,7 @@ regular strings in native encoding. For code, | |||
|
|
|||
| Grammar:: | |||
|
|
|||
| TopLevelObject = 'object' '{' Code? ( Object | Data )* '}' | |||
| Object = 'object' StringLiteral '{' Code? ( Object | Data )* '}' | |||
| Object = 'object' StringLiteral '{' Code ( Object | Data )* '}' | |||
There was a problem hiding this comment.
| Object = 'object' StringLiteral '{' Code ( Object | Data )* '}' | |
| Object = 'object' StringLiteral '{' (Code | Object | Data )+ '}' |
There was a problem hiding this comment.
I think an object has exactly one Code.
There was a problem hiding this comment.
But I don't think code is mandatory, should make it optional then.
There was a problem hiding this comment.
This PR is suggesting that it should be :)
There was a problem hiding this comment.
Having exactly one Code (which could be empty) would also be inline with what the CLI test expects with #5341.
| @@ -559,8 +559,7 @@ regular strings in native encoding. For code, | |||
|
|
|||
| Grammar:: | |||
|
|
|||
| TopLevelObject = 'object' '{' Code? ( Object | Data )* '}' | |||
| Object = 'object' StringLiteral '{' Code? ( Object | Data )* '}' | |||
| Object = 'object' StringLiteral '{' Code ( Object | Data )* '}' | |||
There was a problem hiding this comment.
Having exactly one Code (which could be empty) would also be inline with what the CLI test expects with #5341.
|
Merging for now, we can still change it later. |
