Skip to content

Add LLL chapter in the documentation #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Add LLL chapter in the documentation #5411

merged 1 commit into from
Nov 13, 2018

Conversation

axic
Copy link
Member

@axic axic commented Nov 13, 2018

Closes #5393.

@axic axic requested a review from chriseth November 13, 2018 14:13
ekpyron
ekpyron previously approved these changes Nov 13, 2018
Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, only minor comments.

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@8ed2e02). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #5411   +/-   ##
=========================================
  Coverage           ?   88.1%           
=========================================
  Files              ?     323           
  Lines              ?   32647           
  Branches           ?    3873           
=========================================
  Hits               ?   28763           
  Misses             ?    2585           
  Partials           ?    1299
Flag Coverage Δ
#all 88.1% <ø> (?)
#syntax 28.12% <ø> (?)

docs/lll.rst Outdated

.. _lll:

LLL is a low-level language for the EVM based on s-expressions.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: with an s-expressions syntax.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has like 4-5 acronyms, one other: Little Lovely Language.

I'd avoid it in this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the s-expressions part clarifies that it is "lisp like", but feel free to open a PR with changes to the LLL chapter.

@@ -88,3 +88,4 @@ Contents
bugs.rst
contributing.rst
frequently-asked-questions.rst
lll.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to add another high level entry to the toc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to add another high level entry to the toc?

Yes, that is the easy way to find it. I hope we remove all of LLL with 0.6.0.

@chriseth chriseth merged commit 32d252f into develop Nov 13, 2018
@ekpyron ekpyron deleted the lll-docs branch November 13, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants