[Codegen] Do not perform cleanup on unsigned integers when loading from calldata. #5368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an error during the CI process: Please check that your changes are working as intended. |
chriseth
changed the title
chriseth
force-pushed
the
noCleanupUnsigned
branch
from
f46f171 to
a44243c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5368 +/- ##
===========================================
- Coverage 29.05% 27.94% -1.11%
===========================================
Files 308 323 +15
Lines 31012 32357 +1345
Branches 3744 3872 +128
===========================================
+ Hits 9009 9041 +32
- Misses 21321 22627 +1306
- Partials 682 689 +7
|
chriseth
force-pushed
the
noCleanupUnsigned
branch
from
a44243c to
3920b70
Compare
chriseth
changed the title
axic
reviewed
Nov 14, 2018
| } | ||
| else if (IntegerType const* intType = dynamic_cast<IntegerType const*>(&_type)) | ||
| if (!intType->isSigned()) | ||
| cleanupNeeded = false; |
There was a problem hiding this comment.
Shouldn't this only be a special case for uint256?
There was a problem hiding this comment.
No, because we shift right by the appropriate amount. The use-case in mind actually uses uint32 (the 4 byte function selector).
There was a problem hiding this comment.
Right, this is in the non-32byte branch.
Ah, forgot it is BE and not LE. The code looks good.
axic
previously approved these changes
Nov 14, 2018
axic
force-pushed
the
noCleanupUnsigned
branch
from
3920b70 to
727e3f2
Compare
axic
approved these changes
Nov 14, 2018
|
The docs and archlinux failure is unrelated. |
|
Thank you, looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5319