Add CompilerStack state assertions to internal methods

[axic]

No description provided.

[axic]

Please double check the actual assertion values.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@b7a23ee). Click here to learn what that means.
The diff coverage is 17.64%.

@@            Coverage Diff             @@
##             develop    #4693   +/-   ##
==========================================
  Coverage           ?   28.77%           
==========================================
  Files              ?      314           
  Lines              ?    31610           
  Branches           ?     3748           
==========================================
  Hits               ?     9097           
  Misses             ?    21837           
  Partials           ?      676

Flag	Coverage Δ
#syntax	28.77% <17.64%> (?)

[chriseth]

I'm sorry, but I don't want to review this any further before 0.5.0 release.

[axic]

Rebased and fixed the issue noted. I think this should be safe to merge and would prefer merging it now to give us the 2 weeks time to test it.

[chriseth]

Tests fail.

[axic]

Nvm, it seems in the past month something broke:

Compiling ./contracts/token/ERC827/ERC827Token.sol...

InternalCompilerError:
Compilation failed. See above.

Will investigate.

[axic]

It is actually the link method, seemingly it is called even when without compile.

UNCAUGHT EXCEPTION:
- function: "void dev::solidity::CompilerStack::link()"

[axic]

@chriseth I think it is time to revisit this :)

[axic]

@chriseth do we want to introduce a LinkingSuccessful state?

[chriseth]

Not sure if that makes sense. An object can have unresolved link symbols and calling link does not have to resolve all of them. So in that sense, linking is always successful.

[axic]

Agree, so lets merge this.