Fix cmake when custom CMAKE_INSTALL_LIBDIR is given #4235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to cmake documents, we cannot assume CMAKE_INSTALL_LIBDIR is a relative path. This commit fixes the "no rule to make libjsoncpp.a" error by passing -DCMAKE_INSTALL_LIBDIR=lib to jsoncpp external project.
|
Yes, this is good solution. Exactly the same I proposed 2 days ago in #4221. |
chfast
approved these changes
Jun 6, 2018
chriseth
approved these changes
Jun 6, 2018
|
Wow.. What a coincidence. guess I will close this PR as your are more complete |
resonant-riches
added a commit
to ChorusOne/azimuth-cli
that referenced
this pull request
Mar 4, 2024
Hopefully fix compiler errors on Clang on Apple Silicon. Patches are based on the following upstream PRs: ethereum/solidity#4160 ethereum/solidity#4235 ethereum/solidity#4470 ethereum/solidity#5699 ethereum/solidity#7268 ethereum/solidity#7827 ethereum/solidity#9383 ethereum/solidity#14725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to cmake doc, we cannot assume
CMAKE_INSTALL_LIBDIRis a relative path. People often usecmake -DCMAKE_INSTALL_LIBDIR=/some/custome/library/pathto specify where the libraries should install to.Simply use
libas temporary libdir is probably a solution.Inconsistent
CMAKE_INSTALL_LIBDIRproblem addressed by @aarlt and @chriseth ( #3467 (comment) ) is fixed by passing-DCMAKE_INSTALL_LIBDIR=libto jsoncpp's cmake.We don't need
GNUInstallDirshere because jsoncpp's build is only temporary used anyway.@chfast could you take a look? Thanks so much