Add mutability declaration to example, for #3379 #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2018
chriseth
reviewed
Jan 24, 2018
docs/abi-spec.rst
Outdated
| function sam(bytes name, bool z, uint[] data) public {} | ||
| function bar(bytes3[2]) public pure {} | ||
| function baz(uint32 x, bool y) public pure returns (bool r) { r = x > 32 || y; } | ||
| function sam(bytes name, bool z, uint[] data) public pure {name=name; z=z; data=data;} |
There was a problem hiding this comment.
Did you add name = name; ... to remove the "unused parameter" warning? The recommended way to remove that wouldbe to remove the name of the parameter as you have done for the bar function.
chriseth
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.