eof: Implement stack height calculation #15555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
cameel
added
has dependencies
rodiazet
force-pushed
the
stack-height
branch
3 times, most recently
from
2ae7088
to
692ec4d
Compare
cameel
reviewed
Oct 31, 2024
libevmasm/Assembly.cpp
Outdated
|
|
||
| uint16_t calculateMaxStackHeight(AssemblyItems const& _items, uint16_t _args) | ||
| { | ||
| static auto constexpr LOC_UNVISITED = std::numeric_limits<size_t>::max(); |
There was a problem hiding this comment.
What is LOC?
Suggested change
| static auto constexpr LOC_UNVISITED = std::numeric_limits<size_t>::max(); | |
| static auto constexpr UNVISITED = std::numeric_limits<size_t>::max(); |
There was a problem hiding this comment.
It's taken from evmone. It's LOCation :)
rodiazet
force-pushed
the
stack-height
branch
from
692ec4d
to
7e9e546
Compare
rodiazet
changed the title
rodiazet
force-pushed
the
stack-height
branch
from
7e9e546
to
adc5533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #15550