-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use YulNameRepository instead of YulString for the Yul AST #15281
Draft
clonker
wants to merge
14
commits into
develop
Choose a base branch
from
yul_name_integration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
clonker
commented
Jul 19, 2024
•
edited
Loading
edited
- needs updated test expectations
- depends on PR Yul: Immutable AST class with top-level block #15258
- depends on PR Explicit treatment of printing mode in Yul AsmPrinter #15259
- depends on PR Integrate YulNameRepository as yul dialect proxy #15260
- depends on PR Introduce YulNameRepository #15242
10 tasks
clonker
force-pushed
the
yul_name_integration
branch
from
July 22, 2024 12:19
3de742f
to
e3d9c09
Compare
clonker
added
the
has dependencies
The PR depends on other PRs that must be merged first
label
Jul 31, 2024
github-actions
bot
added
the
stale
The issue/PR was marked as stale because it has been open for too long.
label
Aug 21, 2024
cameel
removed
stale
The issue/PR was marked as stale because it has been open for too long.
closed-due-inactivity
labels
Aug 29, 2024
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
The issue/PR was marked as stale because it has been open for too long.
label
Sep 13, 2024
cameel
removed
the
stale
The issue/PR was marked as stale because it has been open for too long.
label
Sep 13, 2024
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
The issue/PR was marked as stale because it has been open for too long.
label
Sep 28, 2024
cameel
removed
the
stale
The issue/PR was marked as stale because it has been open for too long.
label
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.